You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Way back in 2.0 the constructor took a github.Client directly, which is what Allstar instantiated to then run scorecard checks. With the current code, there is no way to override the built-in roundtripper.NewTransport which uses its own methods to authenticate.
To allow Allstar to use the current code, we need to create this client and provide a pre-authenticated transport (or http client, or github client).
Will we need to make a Scorecard release for AllStar to be able to consume it? If so, please do chime in #1621. We can wait for this PR to go in before cutting the release.
jeffmendoza
changed the title
Add second constructor to allow providing an already authenticated transport
✨ Add second constructor to allow providing an already authenticated transport
Feb 16, 2022
justaugustus
changed the title
✨ Add second constructor to allow providing an already authenticated transport
✨ githubrepo: Allow providing an already authenticated transport
Feb 16, 2022
@jeffmendoza -- Hehe, I just opened a branch for this! Mind if I push a few things on top of this PR?
Will we need to make a Scorecard release for AllStar to be able to consume it? If so, please do chime in #1621. We can wait for this PR to go in before cutting the release.
Merged. Will push any updates as a follow-up! Thanks Jeff!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jeffmendoza
requested review from
azeemshaikh38,
inferno-chromium,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
justaugustus
changed the title
Way back in 2.0 the constructor took a github.Client directly, which is what Allstar instantiated to then run scorecard checks. With the current code, there is no way to override the built-in roundtripper.NewTransport which uses its own methods to authenticate.
To allow Allstar to use the current code, we need to create this client and provide a pre-authenticated transport (or http client, or github client).
cc @justaugustus